netdev - Re: [PATCH 07/31] netfilter: ctnetlink: Support L3 protocol-filter on flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKfDRXgTAcDUddtumR42p1XFSFEYCdYV69YXOG31sE9BtrnrAQ@mail.gmail.com>
Date:   Fri, 3 May 2019 09:14:09 +0200
From:   Kristian Evensen <kristian.evensen@...il.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Netfilter Development Mailing list 
        <netfilter-devel@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH 07/31] netfilter: ctnetlink: Support L3 protocol-filter on flush

Hi,

On Fri, May 3, 2019 at 9:02 AM Nicolas Dichtel
<nicolas.dichtel@...nd.com> wrote:
> >>> Let's use nfgenmsg->version for this. This is so far set to zero. We
> >>> can just update userspace to set it to 1, so family is used.
> >>>
> >>> The version field in the kernel size is ignored so far, so this should
> >>> be enough. So we avoid that extract netlink attribute.
> >>
> >> Why making such a hack? If any userspace app set this field (simply because it's
> >> not initialized), it will show up a new regression.
> >> What is the problem of adding another attribute?
> >
> > The version field was meant to deal with this case.
> >
> > It has been not unused so far because we had no good reason.
> >
> Fair point, agreed.

Great that the discussion has reached a conclusion. I will prepare a
fix based on the version-filed and submit it either later today or
during the weekend. Sorry again for the problems my change caused.

BR,
Kristian