netdev - Re: [PATCH v2 1/5] net: dsa: lantiq: Allow special tags only on CPU port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 May 2019 23:29:34 +0200
From:   Hauke Mehrtens <hauke@...ke-m.de>
To:     Florian Fainelli <f.fainelli@...il.com>, davem@...emloft.net
Cc:     andrew@...n.ch, vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/5] net: dsa: lantiq: Allow special tags only on CPU
 port

On 5/5/19 11:17 PM, Florian Fainelli wrote:
> 
> 
> On 5/5/2019 2:15 PM, Hauke Mehrtens wrote:
>> Allow the special tag in ingress only on the CPU port and not on all
>> ports. A packet with a special tag could circumvent the hardware
>> forwarding and should only be allowed on the CPU port where Linux
>> controls the port.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Does this warrant a Fixes: tag so it gets backported to -stable trees?
> 

Hi Florian,

Yes adding a Fixes tag probably makes sense, someone could use this to
circumvent the switch rules.

Hauke