netdev - Re: [PATCH v2 2/5] net: dsa: lantiq: Add VLAN unaware bridge offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 5 May 2019 14:32:50 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Hauke Mehrtens <hauke@...ke-m.de>, davem@...emloft.net
Cc:     andrew@...n.ch, vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/5] net: dsa: lantiq: Add VLAN unaware bridge
 offloading



On 5/5/2019 2:15 PM, Hauke Mehrtens wrote:
> This allows to offload bridges with DSA to the switch hardware and do
> the packet forwarding in hardware.
> 
> This implements generic functions to access the switch hardware tables,
> which are used to control many features of the switch.
> 
> This patch activates the MAC learning by removing the MAC address table
> lock, to prevent uncontrolled forwarding of packets between all the LAN
> ports, they are added into individual bridge tables entries with
> individual flow ids and the switch will do the MAC learning for each
> port separately before they are added to a real bridge.
> 
> Each bridge consist of an entry in the active VLAN table and the VLAN
> mapping table, table entries with the same index are matching. In the
> VLAN unaware mode we configure everything with VLAN ID 0, but we use
> different flow IDs, the switch should handle all VLANs as normal payload
> and ignore them. When the hardware looks for the port of the destination
> MAC address it only takes the entries which have the same flow ID of the
> ingress packet.
> 
> The bridges are configured with 64 possible entries with these
> information:
> Table Index, 0...63
> VLAN ID, 0...4095: VLAN ID 0 is untagged
> flow ID, 0..63: Same flow IDs share entries in MAC learning table
> port map, one bit for each port number
> tagged port map, one bit for each port number
> 
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>

Reviewe-by: Florian Fainelli <f.fainelli@...il.com>

Looks great and well explained, thanks!
-- 
Florian