netdev - Re: [PATCH net] net: phy: fix phy_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 05 May 2019 01:06:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phy: fix phy_validate_pause

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Wed, 1 May 2019 21:54:28 +0200

> We have valid scenarios where ETHTOOL_LINK_MODE_Pause_BIT doesn't
> need to be supported. Therefore extend the first check to check
> for rx_pause being set.
> 
> See also phy_set_asym_pause:
> rx=0 and tx=1: advertise asym pause only
> rx=0 and tx=0: stop advertising both pause modes
> 
> The fixed commit isn't wrong, it's just the one that introduced the
> linkmode bitmaps.
> 
> Fixes: 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported from u32 to link mode")
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable.