netdev - Re: [PATCH bpf] kbuild: tolerate missing pahole when generating BTF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aed4c5ed-32fc-4ce7-6490-42aa51d41888@iogearbox.net>
Date:   Mon, 6 May 2019 10:19:47 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andriin@...com>, andrii.nakryiko@...il.com,
        netdev@...r.kernel.org, bpf@...r.kernel.org, yhs@...com,
        kernel-team@...com
Cc:     Alexei Starovoitov <ast@...com>
Subject: Re: [PATCH bpf] kbuild: tolerate missing pahole when generating BTF

On 05/06/2019 02:10 AM, Andrii Nakryiko wrote:
> When BTF generation is enabled through CONFIG_DEBUG_INFO_BTF,
> scripts/link-vmlinux.sh detects if pahole version is too old and
> gracefully continues build process, skipping BTF generation build step.
> But if pahole is not available, build will still fail. This patch adds
> check for whether pahole exists at all and bails out gracefully, if not.
> 
> Cc: Alexei Starovoitov <ast@...com>
> Reported-by: Yonghong Song <yhs@...com>
> Fixes: e83b9f55448a ("kbuild: add ability to generate BTF type info for vmlinux")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied, thanks!