netdev - Re: selftests/bpf/test_tag takes ~30 minutes?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec8bdc06-8f61-aab8-9b1d-73045ccb3b64@iogearbox.net>
Date:   Mon, 6 May 2019 11:33:19 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: selftests/bpf/test_tag takes ~30 minutes?

On 04/30/2019 03:21 PM, Michael Ellerman wrote:
> Hi Daniel,
> 
> I'm running selftests/bpf/test_tag and it's taking roughly half an hour
> to complete, is that expected?
> 
> I don't really grok what the test is doing TBH, but it does appear to be
> doing it 5 times :)
> 
> 	for (i = 0; i < 5; i++) {
> 		do_test(&tests, 2, -1,     bpf_gen_imm_prog);
> 		do_test(&tests, 3, fd_map, bpf_gen_map_prog);
> 	}
> 
> Could we make it just do one iteration by default? That would hopefully
> reduce the runtime by quite a bit. It could take a parameter to run the
> longer version perhaps?

On my 2.5 years old laptop it's taking 16 seconds. ;) I'm okay if we
reduce the runs and add a long version via cmdline param. It's basically
comparing the sha based tag generation from the BPF core with plain AF_ALG
from crypto subsys over the same insn sequence to make sure both match fine.

Thanks,
Daniel