netdev - Re: [PATCH bpf] libbpf: remove unnecessary cast-to-void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f46de83-7b76-b7ba-54ed-9b084bb83df8@iogearbox.net>
Date:   Mon, 6 May 2019 11:36:13 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Björn Töpel <bjorn.topel@...il.com>,
        ast@...nel.org, netdev@...r.kernel.org
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        magnus.karlsson@...el.com, magnus.karlsson@...il.com,
        bpf@...r.kernel.org
Subject: Re: [PATCH bpf] libbpf: remove unnecessary cast-to-void

On 05/06/2019 11:24 AM, Björn Töpel wrote:
> From: Björn Töpel <bjorn.topel@...el.com>
> 
> The patches with fixes tags added a cast-to-void in the places when
> the return value of a function was ignored.
> 
> This is not common practice in the kernel, and is therefore removed in
> this patch.
> 
> Reported-by: Daniel Borkmann <daniel@...earbox.net>
> Fixes: 5750902a6e9b ("libbpf: proper XSKMAP cleanup")
> Fixes: 0e6741f09297 ("libbpf: fix invalid munmap call")
> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>

Applied, thanks!