netdev - RE: [net-next v2 11/11] i40e: Introduce recovery mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 May 2019 18:51:02 +0000
From:   "Michael, Alice" <alice.michael@...el.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Marczak, Piotr" <piotr.marczak@...el.com>,
        "Buchholz, Donald" <donald.buchholz@...el.com>
Subject: RE: [net-next v2 11/11] i40e: Introduce recovery mode support



> -----Original Message-----
> From: Jakub Kicinski [mailto:jakub.kicinski@...ronome.com]
> Sent: Saturday, May 4, 2019 4:35 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; Michael, Alice
> <alice.michael@...el.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; nhorman@...hat.com;
> sassmann@...hat.com; Marczak, Piotr <piotr.marczak@...el.com>; Buchholz,
> Donald <donald.buchholz@...el.com>
> Subject: Re: [net-next v2 11/11] i40e: Introduce recovery mode support
> 
> On Fri,  3 May 2019 16:09:39 -0700, Jeff Kirsher wrote:
> > From: Alice Michael <alice.michael@...el.com>
> >
> > This patch introduces "recovery mode" to the i40e driver. It is part
> > of a new Any2Any idea of upgrading the firmware. In this approach, it
> > is required for the driver to have support for "transition firmware",
> > that is used for migrating from structured to flat firmware image. In
> > this new, very basic mode, i40e driver must be able to handle
> > particular IOCTL calls from the NVM Update Tool and run a small set of
> > AQ commands.
> 
> What's the "particular IOCTL" you speak of?  This patch adds a fake netdev with
> a .set_eeprom callback.  Are you wrapping the AQ commands in the set_eeprom
> now?  Or is there some other IOCTL here?

Yes.  The NVMUpdate tool uses the ethtool IOCTL to call the driver's .set_eeprom callback.  This then triggers the firmware AQ command.  The fake netdev needs to have ethtool support to finish upgrading the firmware using the eeprom interface.
 
> Let me repeat my other question - can the netdev you spawn in
> i40e_init_recovery_mode() pass traffic?

No, the device is not expected to pass traffic.  This mode is to allow the NVMUpdate to program the NVM.
 
~Alice