netdev - Re: [PATCH net] nfp: reintroduce ndo_get_port_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 08 May 2019 16:33:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     jiri@...nulli.us, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, pieter.jansenvanvuuren@...ronome.com
Subject: Re: [PATCH net] nfp: reintroduce ndo_get_port_parent_id for
 representor ports

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed,  8 May 2019 15:52:56 -0700

> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> 
> NFP does not register devlink ports for representors (without
> the "devlink: expose PF and VF representors as ports" series
> there are no port flavours to expose them as).
> 
> Commit c25f08ac65e4 ("nfp: remove ndo_get_port_parent_id implementation")
> went to far in removing ndo_get_port_parent_id for representors.
> This causes redirection offloads to fail, and switch_id attribute
> missing.
> 
> Reintroduce the ndo_get_port_parent_id callback for representor ports.
> 
> Fixes: c25f08ac65e4 ("nfp: remove ndo_get_port_parent_id implementation")
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied.