netdev - Re: [PATCH net] net/sched: avoid double free on matchall reoffload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190508.163509.962491051763041431.davem@davemloft.net>
Date:   Wed, 08 May 2019 16:35:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        jiri@...nulli.us, xiyou.wangcong@...il.com,
        pieter.jansenvanvuuren@...ronome.com, dan.carpenter@...cle.com
Subject: Re: [PATCH net] net/sched: avoid double free on matchall reoffload

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed,  8 May 2019 15:56:07 -0700

> From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> 
> Avoid freeing cls_mall.rule twice when failing to setup flow_action
> offload used in the hardware intermediate representation. This is
> achieved by returning 0 when the setup fails but the skip software
> flag has not been set.
> 
> Fixes: f00cbf196814 ("net/sched: use the hardware intermediate representation for matchall")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied.