netdev - Re: [PATCH] net/smc: Fix error path in smc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 May 2019 13:13:20 +0200
From:   Ursula Braun <ubraun@...ux.ibm.com>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        kgraul@...ux.ibm.com, hwippel@...ux.ibm.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH] net/smc: Fix error path in smc_init



On 5/14/19 8:39 AM, YueHaibing wrote:
> If register_pernet_subsys success in smc_init,
> we should cleanup it in case any other error.
> 

Thanks, looks good. Your patch will be part of our next patch
submission.

Regards, Ursula

> Fixes: 64e28b52c7a6 (net/smc: add pnet table namespace support")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  net/smc/af_smc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 6f869ef..7d3207f 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -2019,7 +2019,7 @@ static int __init smc_init(void)
>  
>  	rc = smc_pnet_init();
>  	if (rc)
> -		return rc;
> +		goto out_pernet_subsys;
>  
>  	rc = smc_llc_init();
>  	if (rc) {
> @@ -2070,6 +2070,9 @@ static int __init smc_init(void)
>  	proto_unregister(&smc_proto);
>  out_pnet:
>  	smc_pnet_exit();
> +out_pernet_subsys:
> +	unregister_pernet_subsys(&smc_net_ops);
> +
>  	return rc;
>  }
>  
>