netdev - Re: [PATCH net] net/mlx4_core: Change the error print to info print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e68afdbd-49eb-f75a-a6a2-177e873217ab@mellanox.com>
Date:   Tue, 14 May 2019 11:28:41 +0000
From:   Tariq Toukan <tariqt@...lanox.com>
To:     wangyunjian <wangyunjian@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Tariq Toukan <tariqt@...lanox.com>,
        "xudingke@...wei.com" <xudingke@...wei.com>
Subject: Re: [PATCH net] net/mlx4_core: Change the error print to info print



On 5/14/2019 2:03 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
> 
> The error print within mlx4_flow_steer_promisc_add() should
> be a info print.
> 
> Fixes: 592e49dda812 ('net/mlx4: Implement promiscuous mode with device managed flow-steering')
> Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/mcg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> index ffed2d4..9c48182 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> @@ -1492,7 +1492,7 @@ int mlx4_flow_steer_promisc_add(struct mlx4_dev *dev, u8 port,
>   	rule.port = port;
>   	rule.qpn = qpn;
>   	INIT_LIST_HEAD(&rule.list);
> -	mlx4_err(dev, "going promisc on %x\n", port);
> +	mlx4_info(dev, "going promisc on %x\n", port);
>   
>   	return  mlx4_flow_attach(dev, &rule, regid_p);
>   }
> 

LGTM.
Reviewed-by: Tariq Toukan <tariqt@...lanox.com>

Thanks,
Tariq