netdev - Re: [PATCH 2/2] rhashtable: Fix cmpxchg RCU warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 May 2019 20:42:36 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "tgraf@...g.ch" <tgraf@...g.ch>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
        "neilb@...e.com" <neilb@...e.com>,
        Simon Horman <simon.horman@...ronome.com>
Subject: Re: [PATCH 2/2] rhashtable: Fix cmpxchg RCU warnings

On Thu, May 16, 2019 at 09:20:36AM +0000, David Laight wrote:
>
> I presume these casts remove an 'rcu' marker on the variable.
> Is there a way of marking such casts as 'for sparse only' so
> that the compiler does proper type checking.
> (Clearly this isn't that relevant here as the cast could be (void **).)
> 
> Hmmm something should be checking that the type of the argument
> to cmpxchg is 'pointer to "something the size of a pointer"'
> Adding any kind of cast subverts that test.

If we were adding this as an RCU primitive then yes that what
it should do.  But it isn't relevant to this patch.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt