netdev - Re: [PATCH net] selftests: pmtu.sh: Remove quotes around commands in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190516195140.158e602f@redhat.com>
Date:   Thu, 16 May 2019 19:51:40 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net] selftests: pmtu.sh: Remove quotes around commands
 in setup_xfrm

On Thu, 16 May 2019 10:41:31 -0700
David Ahern <dsahern@...nel.org> wrote:

> From: David Ahern <dsahern@...il.com>
> 
> The first command in setup_xfrm is failing resulting in the test getting
> skipped:
> 
> + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
> + out=RTNETLINK answers: Function not implemented

Thanks for fixing this, I ran into this issue right today and I was
about to send a patch too. For the record, the quotes went all the way
into xfrm_alg_name_match():

	name: 'rfc4106(gcm(aes))'
	entry->name: rfc4106(gcm(aes))

My solution was to remove the single quotes around 'rfc4106(gcm(aes))',
but I just checked yours and it also works on bash and dash, so I don't
really have a preference.

> ...
>   xfrm6 not supported
> TEST: vti6: PMTU exceptions                                         [SKIP]
>   xfrm4 not supported
> TEST: vti4: PMTU exceptions                                         [SKIP]
> ...
> 
> The setup command started failing when the run_cmd option was added.
> Removing the quotes fixes the problem:
> ...
> TEST: vti6: PMTU exceptions                                         [ OK ]
> TEST: vti4: PMTU exceptions                                         [ OK ]
> ...
> 
> Fixes: 56490b623aa0 ("selftests: Add debugging options to pmtu.sh")
> Signed-off-by: David Ahern <dsahern@...il.com>

Reviewed-and-tested-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano