lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 16 May 2019 11:53:55 -0600
From:   David Ahern <>
To:     Stefano Brivio <>,
        David Ahern <>
Subject: Re: [PATCH net] selftests: Remove quotes around commands in

On 5/16/19 11:51 AM, Stefano Brivio wrote:
> On Thu, 16 May 2019 10:41:31 -0700
> David Ahern <> wrote:
>> From: David Ahern <>
>> The first command in setup_xfrm is failing resulting in the test getting
>> skipped:
>> + ip netns exec ns-B ip -6 xfrm state add src fd00:1::a dst fd00:1::b spi 0x1000 proto esp aead 'rfc4106(gcm(aes))' 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f 128 mode tunnel
>> + out=RTNETLINK answers: Function not implemented
> Thanks for fixing this, I ran into this issue right today and I was
> about to send a patch too. For the record, the quotes went all the way
> into xfrm_alg_name_match():
> 	name: 'rfc4106(gcm(aes))'
> 	entry->name: rfc4106(gcm(aes))
> My solution was to remove the single quotes around 'rfc4106(gcm(aes))',
> but I just checked yours and it also works on bash and dash, so I don't
> really have a preference.

None of the other commands have the "" with run_cmd. Not sure why I did
not remove the quotes from the xfrm commands.

Powered by blists - more mailing lists