netdev - Re: [PATCH net] ipv6: fix src addr routing with the exception table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ab0f808-bcd9-0f6f-9d88-c1272493b6d9@gmail.com>
Date:   Wed, 15 May 2019 18:06:58 -0600
From:   David Ahern <dsahern@...il.com>
To:     Wei Wang <weiwan@...gle.com>, Martin Lau <kafai@...com>
Cc:     Wei Wang <tracywwnj@...il.com>, David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Mikael Magnusson <mikael.kernel@...ts.m7n.se>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net] ipv6: fix src addr routing with the exception table

On 5/15/19 6:03 PM, Wei Wang wrote:
> Thanks Martin.
> Changing __rt6_find_exception_xxx() might not be easy cause other
> callers of this function does not really need to back off and use
> another saddr.
> And the validation of the result is a bit different for different callers.
> What about add a new helper for the above 2 cases and just call that
> from both places?

Since this needs to be backported to stable releases, I would say
simplest patch for that is best.

I have changes queued for this area once net-next opens; I can look at
consolidating as part of that.