lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 May 2019 06:49:17 +0000 From: Roi Dayan <roid@...lanox.com> To: wenxu <wenxu@...oud.cn>, Saeed Mahameed <saeedm@...lanox.com>, Gavi Teitz <gavi@...lanox.com>, Vlad Buslov <vladbu@...lanox.com>, Jianbo Liu <jianbol@...lanox.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH] net/mlx5e: restrict the real_dev of vlan device is the same as uplink device On 18/05/2019 06:10, wenxu wrote: > There will be multiple vlan device which maybe not belong to the uplink rep device, so wen can limit it > > 在 2019/5/18 4:30, Saeed Mahameed 写道: >> On Wed, 2019-05-15 at 17:25 +0800, wenxu@...oud.cn wrote: >>> From: wenxu <wenxu@...oud.cn> >>> >>> When register indr block for vlan device, it should check the >>> real_dev >>> of vlan device is same as uplink device. Or it will set offload rule >>> to mlx5e which will never hit. >>> >> I would improve the commit message, it is not really clear to me what >> is going on here. >> >> Anyway Roi and team, can you please provide feedback .. >> >>> Signed-off-by: wenxu <wenxu@...oud.cn> >>> --- >>> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c >>> b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c >>> index 91e24f1..a39fdac 100644 >>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c >>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c >>> @@ -796,7 +796,7 @@ static int mlx5e_nic_rep_netdevice_event(struct >>> notifier_block *nb, >>> struct net_device *netdev = netdev_notifier_info_to_dev(ptr); >>> >>> if (!mlx5e_tc_tun_device_to_offload(priv, netdev) && >>> - !is_vlan_dev(netdev)) >>> + !(is_vlan_dev(netdev) && vlan_dev_real_dev(netdev) == >>> rpriv->netdev)) >>> return NOTIFY_OK; >>> >>> switch (event) { thanks! you should add a fixes line Fixes: 35a605db168c ("net/mlx5e: Offload TC e-switch rules with ingress VLAN device") beside that all good. Reviewed-by: Roi Dayan <roid@...lanox.com>
Powered by blists - more mailing lists