netdev - Re: [PATCH] net: Treat sock->sk_drops as an unsigned int when printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190519.103158.398765503030510997.davem@davemloft.net>
Date:   Sun, 19 May 2019 10:31:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ptalbert@...hat.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: Treat sock->sk_drops as an unsigned int when
 printing

From: Patrick Talbert <ptalbert@...hat.com>
Date: Fri, 17 May 2019 17:11:28 +0200

> Currently, procfs socket stats format sk_drops as a signed int (%d). For large
> values this will cause a negative number to be printed.
> 
> We know the drop count can never be a negative so change the format specifier to
> %u.
> 
> Signed-off-by: Patrick Talbert <ptalbert@...hat.com>

Yep, looks reasonable, applied.