lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 20 May 2019 11:22:21 -0700
From:   Florian Fainelli <>
To:     Russell King <>,
        "David S. Miller" <>
Cc:     Vladimir Oltean <>, Andrew Lunn <>,
        Heiner Kallweit <>,
Subject: Re: [PATCH net-next 1/4] net: phylink: support for link gpio

On 5/20/19 8:22 AM, Russell King wrote:
> Add support for using GPIO interrupts with a fixed-link GPIO rather than
> polling the GPIO every second and invoking the phylink resolution.  This
> avoids unnecessary calls to mac_config().
> Signed-off-by: Russell King <>

Reviewed-by: Florian Fainelli <>

Just one comment, see below:


> -	if (pl->link_an_mode == MLO_AN_FIXED && !IS_ERR(pl->link_gpio))
> -		del_timer_sync(&pl->link_poll);
> +	del_timer_sync(&pl->link_poll);

Removing a timer that was only set-up if pl->link_an_mode ==
MLO_AN_FIXED probably does not hurt, but this breaks symmetry a bit here.

Powered by blists - more mailing lists