lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 May 2019 11:22:21 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Russell King <rmk+kernel@...linux.org.uk>, "David S. Miller" <davem@...emloft.net> Cc: Vladimir Oltean <olteanv@...il.com>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH net-next 1/4] net: phylink: support for link gpio interrupt On 5/20/19 8:22 AM, Russell King wrote: > Add support for using GPIO interrupts with a fixed-link GPIO rather than > polling the GPIO every second and invoking the phylink resolution. This > avoids unnecessary calls to mac_config(). > > Signed-off-by: Russell King <rmk+kernel@...linux.org.uk> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> Just one comment, see below: [snip] > - if (pl->link_an_mode == MLO_AN_FIXED && !IS_ERR(pl->link_gpio)) > - del_timer_sync(&pl->link_poll); > + del_timer_sync(&pl->link_poll); Removing a timer that was only set-up if pl->link_an_mode == MLO_AN_FIXED probably does not hurt, but this breaks symmetry a bit here. -- Florian
Powered by blists - more mailing lists