netdev - Re: [PATCH net-next 0/4] phylink/sfp updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 May 2019 18:40:22 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        netdev <netdev@...r.kernel.org>, ioana.ciornei@....com
Subject: Re: [PATCH net-next 0/4] phylink/sfp updates

On Mon, 20 May 2019 at 18:21, Russell King - ARM Linux admin
<linux@...linux.org.uk> wrote:
>
> Hi,
>
> I realise that net-next probably isn't open yet, but I believe folk
> will find these patches "interesting" so I'm sending them to share
> them with people working on this code, rather than expecting them to
> be picked up this week.
>
> The first patch adds support for using interrupts when using a GPIO
> for link status tracking, rather than polling it at one second
> intervals.  This reduces the need to wakeup the CPU every second.
>
> The second patch adds support to the MII ioctl API to read and write
> Clause 45 PHY registers.  I don't know how desirable this is for
> mainline, but I have used this facility extensively to investigate
> the Marvell 88x3310 PHY.
>
> There have been discussions about removing "netdev" from phylink.
> The last two patches remove netdev from the sfp code, which would be
> a necessary step in that direction.

Hi Russell,

I've been working with Ioana to introduce a
phylink_create_raw/phylink_attach_raw set of function that work in the
absence of an attached_dev. It does not remove the netdev references
from the existing code, just guards the few places that needed that.
Then we plugged it into DSA (via a notifier block) and now phylink is
used for both the user and non-user ports. Next step is to make the
dpaa2-mac driver use this new API and send the patchset for review.
Hopefully that will happen tomorrow.

-Vladimir

>
>  drivers/net/phy/phy.c     | 33 ++++++++++++++++++++--------
>  drivers/net/phy/phylink.c | 55 +++++++++++++++++++++++++++++++++++++++++------
>  drivers/net/phy/sfp-bus.c | 14 +++++-------
>  include/linux/sfp.h       | 12 +++++++----
>  4 files changed, 86 insertions(+), 28 deletions(-)
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up