netdev - Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190521121311.GW18865@dhcp-12-139.nay.redhat.com>
Date:   Tue, 21 May 2019 20:13:11 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        Phil Sutter <phil@....cc>
Subject: Re: [PATCH iproute2 net-next] ip: add a new parameter -Numeric

On Mon, May 20, 2019 at 10:03:22AM -0700, Stephen Hemminger wrote:
> On Mon, 20 May 2019 09:18:08 -0600
> David Ahern <dsahern@...il.com> wrote:
> 
> > On 5/20/19 1:56 AM, Hangbin Liu wrote:
> > > When calles rtnl_dsfield_n2a(), we get the dsfield name from
> > > /etc/iproute2/rt_dsfield. But different distribution may have
> > > different names. So add a new parameter '-Numeric' to only show
> > > the dsfield number.
> > > 
> > > This parameter is only used for tos value at present. We could enable
> > > this for other fields if needed in the future.
> > > 
> > 
> > It does not make sense to add this flag just for 1 field.
> > 
> > 3 years ago I started a patch to apply this across the board. never
> > finished it. see attached. The numeric variable should be moved to
> > lib/rt_names.c. It handles all of the conversions in that file - at
> > least as of May 2016.
> 
> 
> Agree, if you are going to do it, go all in.
> Handle all types and in same manner for ip, tc, bridge, and devlink.
> ss already has -numeric option.

OK, I will do it.

BTW, for some pre-defined names in iproute2, like rtnl_rtprot_tab,
nl_proto_tab. Should we also print the number directly or just keep
using the human readable names?

I would like to keep them as this is defined in iproute and we can control
them. But this may make people feel confused with the -Numeric parameter.
So what do you think?

Thanks
Hangbin