netdev - Re: [PATCH net,stable 1/1] net: fec: fix the clk mismatch in failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 23 May 2019 11:06:46 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Andy Duan <fugang.duan@....com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Shawn Guo <shawnguo@...nel.org>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH net,stable 1/1] net: fec: fix the clk mismatch in
 failed_reset path

Hi Andy,

On Thu, May 23, 2019 at 01:55:28AM +0000, Andy Duan wrote:
> Fix the clk mismatch in the error path "failed_reset" because
> below error path will disable clk_ahb and clk_ipg directly, it
> should use pm_runtime_put_noidle() instead of pm_runtime_put()
> to avoid to call runtime resume callback.
> 
> Reported-by: Baruch Siach <baruch@...s.co.il>
> Signed-off-by: Fugang Duan <fugang.duan@....com>

Tested-by: Baruch Siach <baruch@...s.co.il>

Tested on SolidRun Hummingboard Pulse.

Thanks.

But please avoid sending patched in base64 encoded emails. Plaintext is much 
easier when dealing with 'git am'.

baruch

> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index f63eb2b..848defa 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3555,7 +3555,7 @@ fec_probe(struct platform_device *pdev)
>  	if (fep->reg_phy)
>  		regulator_disable(fep->reg_phy);
>  failed_reset:
> -	pm_runtime_put(&pdev->dev);
> +	pm_runtime_put_noidle(&pdev->dev);
>  	pm_runtime_disable(&pdev->dev);
>  failed_regulator:
>  	clk_disable_unprepare(fep->clk_ahb);

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -