netdev - Re: [PATCH net,stable 1/1] net: fec: add defer probe for of_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 13:11:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fugang.duan@....com
Cc:     netdev@...r.kernel.org, baruch@...s.co.il
Subject: Re: [PATCH net,stable 1/1] net: fec: add defer probe for
 of_get_mac_address

From: Andy Duan <fugang.duan@....com>
Date: Thu, 23 May 2019 01:55:23 +0000

> @@ -3146,7 +3150,10 @@ static int fec_enet_init(struct net_device *ndev)
>  	memset(cbd_base, 0, bd_size);
>  
>  	/* Get the Ethernet address */
> -	fec_get_mac(ndev);
> +	ret = fec_get_mac(ndev);
> +	if (ret)
> +		return ret;

You're leaking the queues allocated by fec_enet_alloc_queue().