netdev - Re: [PATCH 7/8] net: ethernet: ixp4xx: Add DT bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190524200651.GQ21208@lunn.ch>
Date:   Fri, 24 May 2019 22:06:51 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Krzysztof Halasa <khalasa@...p.pl>
Subject: Re: [PATCH 7/8] net: ethernet: ixp4xx: Add DT bindings

> +description: |
> +  The Intel IXP4xx ethernet makes use of the IXP4xx NPE (Network
> +  Processing Engine) and the IXP4xx Queue Mangager to process
> +  the ethernet frames. It can optionally contain an MDIO bus to
> +  talk to PHYs.

Hi Linus

You mention MDIO and PHYs, but the code is not there yet. When you do
add the needed code, it is a good idea to place the PHY nodes inside a
container node:

    ethernet@...09000 {
        compatible = "intel,ixp4xx-ethernet";
        reg = <0xc8009000 0x1000>;
        status = "disabled";
        queue-rx = <&qmgr 3>;
        queue-txready = <&qmgr 20>;

        mdio {
		phy0: phy@0 {
		      reg = <0>;
		};
	};
    };

    Andrew