netdev - Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190523.091106.645519899189717299.davem@davemloft.net>
Date:   Thu, 23 May 2019 09:11:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ast@...dv.de
Cc:     netdev@...r.kernel.org
Subject: Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs

From: Andreas Steinmetz <ast@...dv.de>
Date: Thu, 23 May 2019 09:46:15 +0200

> MACsec causes oopses followed by a kernel panic when attached directly or indirectly to a bridge. It causes erroneous
> checksum messages when attached to vxlan. When I did investigate I did find skb leaks, apparent skb mis-handling and
> superfluous code. The attached patch fixes all MACsec misbehaviour I could find. As I am no kernel developer somebody
> with sufficient kernel network knowledge should verify and correct the patch where necessary.
> 
> Signed-off-by: Andreas Steinmetz <ast@...dv.de>

Subject lines should be of the form:

[PATCH $DST_TREE] $subsystem_prefix: Description.

Where $DST_TREE here would be "net" and $subsystem_prefix would be "macsec".

> +	/* FIXME: any better way to prevent calls to netdev_rx_csum_fault? */
> +	skb->csum_complete_sw = 1;

Create a helper for this in linux/skbuff.h with very clear and clean comments
explaining what is going on.