netdev - Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 12:09:14 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Andreas Steinmetz <ast@...dv.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [RESEND][PATCH] Fix MACsec kernel panics, oopses and bugs

Hi Andreas,

2019-05-23, 09:46:15 +0200, Andreas Steinmetz wrote:
> MACsec causes oopses followed by a kernel panic when attached
> directly or indirectly to a bridge. It causes erroneous checksum
> messages when attached to vxlan.

It looks like you're fixing multiple separate bugs in a single patch,
which makes it really difficult to understand. You're also not
describing what the issues are, and why the changes you're proposing
are fixing those bugs.

Do you have reproducers for those bugs? That would be helpful, as I've
never seen the panics/leaks/checksum issues you're mentioning.

> When I did investigate I did find skb leaks, apparent skb mis-handling and
> superfluous code. The attached patch fixes all MACsec misbehaviour I could find.

Please fix only one issue per patch. Otherwise, it's really hard to
tell what change fixes which issue.

Thanks,

-- 
Sabrina