lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <03871bd5-f285-140b-0c32-4e809ca938b5@gmail.com> Date: Wed, 22 May 2019 19:02:16 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Ioana Ciornei <ioana.ciornei@....com>, "linux@...linux.org.uk" <linux@...linux.org.uk>, "andrew@...n.ch" <andrew@...n.ch>, "hkallweit1@...il.com" <hkallweit1@...il.com>, "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>, "olteanv@...il.com" <olteanv@...il.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [RFC PATCH net-next 2/9] net: phy: Guard against the presence of a netdev On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > A prerequisite for PHYLIB to work in the absence of a struct net_device > is to not access pointers to it. > > Changes are needed in the following areas: > > - Printing: In some places netdev_err was replaced with phydev_err. > > - Incrementing reference count to the parent MDIO bus driver: If there > is no net device, then the reference count should definitely be > incremented since there is no chance that it was an Ethernet driver > who registered the MDIO bus. > > - Sysfs links are not created in case there is no attached_dev. > > - No netif_carrier_off is done if there is no attached_dev. > > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com> > Signed-off-by: Vladimir Oltean <olteanv@...il.com> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian
Powered by blists - more mailing lists