lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8e954092-852b-6e69-a10f-8da480ba8749@gmail.com> Date: Wed, 22 May 2019 19:05:04 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Ioana Ciornei <ioana.ciornei@....com>, "linux@...linux.org.uk" <linux@...linux.org.uk>, "andrew@...n.ch" <andrew@...n.ch>, "hkallweit1@...il.com" <hkallweit1@...il.com>, "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>, "olteanv@...il.com" <olteanv@...il.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [RFC PATCH net-next 3/9] net: phy: Add phy_standalone sysfs entry On 5/22/2019 6:20 PM, Ioana Ciornei wrote: > Export a phy_standalone device attribute that is meant to give the > indication that this PHY lacks an attached_dev and its corresponding > sysfs link. > > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com> I would rather have that attribute be conditionally visible/created upon a PHY device being associated with a NULL net_device and not have it for "non-standalone" PHY devices, that would be confusing. > --- > drivers/net/phy/phy_device.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 25cc7c33f8dd..30e0e73d5f86 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -537,10 +537,22 @@ phy_has_fixups_show(struct device *dev, struct device_attribute *attr, > } > static DEVICE_ATTR_RO(phy_has_fixups); > > +static ssize_t phy_standalone_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct phy_device *phydev = to_phy_device(dev); > + > + return sprintf(buf, "%d\n", !phydev->attached_dev); > +} > + > +static DEVICE_ATTR_RO(phy_standalone); > + > static struct attribute *phy_dev_attrs[] = { > &dev_attr_phy_id.attr, > &dev_attr_phy_interface.attr, > &dev_attr_phy_has_fixups.attr, > + &dev_attr_phy_standalone.attr, > NULL, > }; > ATTRIBUTE_GROUPS(phy_dev); > -- Florian
Powered by blists - more mailing lists