netdev - Re: [RFC PATCH net-next 8/9] net: dsa: Use PHYLINK for the CPU/DSA ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hpRrEqe82iMp5euimdBbKMAW2M6T3kr09z7L=S9kkOrGQ@mail.gmail.com>
Date:   Fri, 24 May 2019 16:44:17 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [RFC PATCH net-next 8/9] net: dsa: Use PHYLINK for the CPU/DSA ports

On Fri, 24 May 2019 at 16:19, Andrew Lunn <andrew@...n.ch> wrote:
>
> > Hi Florian,
> >
> > Yes we could, but since most of the adjust_link -> phylink_mac_ops
> > changes appear trivial, and we have the knowledge behind b53 right
> > here, can't we just migrate everything in the next patchset and remove
> > adjust_link altogether from DSA?
>
> I agree with Florian, we either need to support both, or their needs
> to be another patchset which comes first and converts all DSA drivers
> to PHYLINK. And it is this conversion patchset which is likely to
> break things, so it would be good to sit in net-next for a week or two
> to allow testing, before the second patchset is applied.
>
>    Andrew

Hi Andrew,

I think that converting drivers to PHYLINK in a separate patchset is
going to introduce useless work, since the complete migration to
PHYLINK is necessarily going to take 2 steps. As of now, the CPU and
DSA ports still use the PHYLIB adjust_link callback exclusively.
So let's see what the drivers need to do in adjust_link now and how to
map that over phylink_mac_config, and in v2 we can just remove the
adjust_link wrappers completely from DSA.

-Vladimir