netdev - Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93ee56f3-6e58-5c16-a20a-0aa6330741f7@mojatatu.com>
Date:   Fri, 24 May 2019 10:44:17 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Edward Cree <ecree@...arflare.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Jiri Pirko <jiri@...nulli.us>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Michael Chan <michael.chan@...adcom.com>,
        Vishal Kulkarni <vishal@...lsio.com>
Subject: Re: [PATCH v3 net-next 0/3] flow_offload: Re-add per-action
 statistics

On 2019-05-24 9:57 a.m., Edward Cree wrote:
> On 24/05/2019 14:09, Edward Cree wrote:
>> I'll put together an RFC patch, anyway
> Argh, there's a problem: an action doesn't have a (directly) associated
>   block, and all the TC offload machinery nowadays is built around blocks.
> Since this action might have been used in _any_ block (and afaik there's
>   no way, from the action, to find which) we'd have to make callbacks on
>   _every_ block in the system, which sounds like it'd perform even worse
>   than the rule-dumping approach.
> Any ideas?

If you have the hardware just send the stats periodically to the kernel
and manage to map each stat to an action type/index (which i think your
cookie seemed able to do) wouldnt this solve the problem?

cheers,
jamal