netdev - Re: [PATCH] net:phy:dp83867: set up rgmii tx delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 07:37:58 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Max Uvarov <muvarov@...il.com>, netdev@...r.kernel.org
Cc:     andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net
Subject: Re: [PATCH] net:phy:dp83867: set up rgmii tx delay



On 5/24/2019 3:35 AM, Max Uvarov wrote:
> PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
> so code to set tx delay is never called.
> 
> Signed-off-by: Max Uvarov <muvarov@...il.com>

Could you provide an appropriate Fixes: tag for this as well as fix the
subject to be:

net: phy: dp83867: Set up RGMII TX delay

(sorry for being uber nitpicking on this)

> ---
>  drivers/net/phy/dp83867.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> index 2984fd5ae495..5fed837665ea 100644
> --- a/drivers/net/phy/dp83867.c
> +++ b/drivers/net/phy/dp83867.c
> @@ -251,10 +251,8 @@ static int dp83867_config_init(struct phy_device *phydev)
>  		ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);
>  		if (ret)
>  			return ret;
> -	}
>  

Is this hunk ^ intentional?

> -	if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
> -	    (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
> +		/* Set up RGMII delays */
>  		val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL);
>  
>  		if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
> 

-- 
Florian