netdev - Re: [PATCH] net:phy:dp83867: set up rgmii tx delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 May 2019 22:46:18 +0300
From:   Maxim Uvarov <muvarov@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH] net:phy:dp83867: set up rgmii tx delay

пт, 24 мая 2019 г. в 17:37, Florian Fainelli <f.fainelli@...il.com>:
>
>
>
> On 5/24/2019 3:35 AM, Max Uvarov wrote:
> > PHY_INTERFACE_MODE_RGMII_RXID is less then TXID
> > so code to set tx delay is never called.
> >
> > Signed-off-by: Max Uvarov <muvarov@...il.com>
>
> Could you provide an appropriate Fixes: tag for this as well as fix the
> subject to be:
>
> net: phy: dp83867: Set up RGMII TX delay
>
> (sorry for being uber nitpicking on this)
>
> > ---
> >  drivers/net/phy/dp83867.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
> > index 2984fd5ae495..5fed837665ea 100644
> > --- a/drivers/net/phy/dp83867.c
> > +++ b/drivers/net/phy/dp83867.c
> > @@ -251,10 +251,8 @@ static int dp83867_config_init(struct phy_device *phydev)
> >               ret = phy_write(phydev, MII_DP83867_PHYCTRL, val);
> >               if (ret)
> >                       return ret;
> > -     }
> >
>
> Is this hunk ^ intentional?
>

yes. Might be hard to see idea in patch without looking to the code.
But it just removes if bellow and puts the code to upper if stametent.
Which is if rgmii().
That is needed for connection type rgmi-txid which has actual setting bellow.

Max.

> > -     if ((phydev->interface >= PHY_INTERFACE_MODE_RGMII_ID) &&
> > -         (phydev->interface <= PHY_INTERFACE_MODE_RGMII_RXID)) {
> > +             /* Set up RGMII delays */
> >               val = phy_read_mmd(phydev, DP83867_DEVADDR, DP83867_RGMIICTL);
> >
> >               if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID)
> >
>
> --
> Florian