netdev - Re: [PATCH v3 bpf-next 1/6] bpf: Create BPF_PROG_CGROUP_INET_EGRESS_RUN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20950DF0-15BC-4F15-AD5E-503A323EC39A@fb.com>
Date:   Tue, 28 May 2019 21:23:56 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        netdev <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>
CC:     Martin Lau <kafai@...com>, Alexei Starovoitov <ast@...com>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 1/6] bpf: Create
 BPF_PROG_CGROUP_INET_EGRESS_RUN_ARRAY


On 5/28/19, 1:43 PM, "Eric Dumazet" <eric.dumazet@...il.com> wrote:

     
    On 5/28/19 11:54 AM, Lawrence Brakmo wrote:
    > On 5/28/19, 6:43 AM, "netdev-owner@...r.kernel.org on behalf of Eric Dumazet" <netdev-owner@...r.kernel.org on behalf of eric.dumazet@...il.com> wrote:
    > 
    
    >     Why are you using preempt_enable_no_resched() here ?
    > 
    > Because that is what __BPF_PROG_RUN_ARRAY() calls and the macro
    > BPF_PROG_CGROUP_INET_EGRESS_RUN_ARRAY() is an instantiation of it
    > (with minor changes in the return value).
    
    I do not see this in my tree.
    
    Please rebase your tree, do not bring back an issue that was solved already.

My mistake. My tree is up to date, I looked in the wrong place and did
not realized the call had changed. I will fix it and resubmit again.
Thank you for the feedback.