lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190528154510.41b50723@cakuba.netronome.com> Date: Tue, 28 May 2019 15:45:10 -0700 From: Jakub Kicinski <jakub.kicinski@...ronome.com> To: Vedang Patel <vedang.patel@...el.com> Cc: netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com, davem@...emloft.net, jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us, intel-wired-lan@...ts.osuosl.org, vinicius.gomes@...el.com, l@...ileo.org Subject: Re: [PATCH net-next v1 3/7] taprio: Add the skeleton to enable hardware offloading On Tue, 28 May 2019 10:46:44 -0700, Vedang Patel wrote: > From: Vinicius Costa Gomes <vinicius.gomes@...el.com> > > This adds the UAPI and the core bits necessary for userspace to > request hardware offloading to be enabled. > > The future commits will enable hybrid or full offloading for taprio. This > commit sets up the infrastructure to enable it via the netlink interface. > > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@...el.com> > Signed-off-by: Vedang Patel <vedang.patel@...el.com> Other qdiscs offload by default, this offload-level selection here is a little bit inconsistent with that :( > @@ -731,6 +857,9 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt, > if (err < 0) > return err; > > + if (tb[TCA_TAPRIO_ATTR_OFFLOAD_FLAGS]) > + offload_flags = nla_get_u32(tb[TCA_TAPRIO_ATTR_OFFLOAD_FLAGS]); You should make sure user doesn't set unknown bits. Otherwise using other bits will not be possible in the future. > new_admin = kzalloc(sizeof(*new_admin), GFP_KERNEL); > if (!new_admin) { > NL_SET_ERR_MSG(extack, "Not enough memory for a new schedule");
Powered by blists - more mailing lists