[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190528225005.10628-1-olteanv@gmail.com>
Date: Wed, 29 May 2019 01:50:03 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
davem@...emloft.net
Cc: ioana.ciornei@....com, netdev@...r.kernel.org,
Vladimir Oltean <olteanv@...il.com>
Subject: [PATCH net 0/2] Fixes for DSA tagging using 802.1Q
During the prototyping for the "Decoupling PHYLINK from struct
net_device" patchset, the CPU port of the sja1105 driver was moved to a
different spot. This uncovered an issue in the tag_8021q DSA code,
which used to work by mistake - the CPU port was the last hardware port
numerically, and this was masking an ordering issue which is very likely
to be seen in other drivers that make use of 802.1Q tags.
A question was also raised whether the VID numbers bear any meaning, and
the conclusion was that they don't, at least not in an absolute sense.
The second patch defines bit fields inside the DSA 802.1Q VID so that
tcpdump can decode it unambiguously (although the meaning is now clear
even by visual inspection).
Ioana Ciornei (1):
net: dsa: tag_8021q: Change order of rx_vid setup
Vladimir Oltean (1):
net: dsa: tag_8021q: Create a stable binary format
net/dsa/tag_8021q.c | 73 ++++++++++++++++++++++++++++++++++++---------
1 file changed, 59 insertions(+), 14 deletions(-)
--
2.17.1
Powered by blists - more mailing lists