netdev - Re: [PATCH net 1/2] net: dsa: tag_8021q: Change order of rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72a6d3a2-1ef4-d68e-1c34-610da37975a0@gmail.com>
Date:   Tue, 28 May 2019 16:10:08 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, vivien.didelot@...il.com,
        andrew@...n.ch, davem@...emloft.net
Cc:     ioana.ciornei@....com, netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: dsa: tag_8021q: Change order of rx_vid setup

On 5/28/19 3:50 PM, Vladimir Oltean wrote:
> From: Ioana Ciornei <ioana.ciornei@....com>
> 
> The 802.1Q tagging performs an unbalanced setup in terms of RX VIDs on
> the CPU port. For the ingress path of a 802.1Q switch to work, the RX
> VID of a port needs to be seen as tagged egress on the CPU port.
> 
> While configuring the other front-panel ports to be part of this VID,
> for bridge scenarios, the untagged flag is applied even on the CPU port
> in dsa_switch_vlan_add.  This happens because DSA applies the same flags
> on the CPU port as on the (bridge-controlled) slave ports, and the
> effect in this case is that the CPU port tagged settings get deleted.
> 
> Instead of fixing DSA by introducing a way to control VLAN flags on the
> CPU port (and hence stop inheriting from the slave ports) - a hard,
> perhaps intractable problem - avoid this situation by moving the setup
> part of the RX VID on the CPU port after all the other front-panel ports
> have been added to the VID.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>
> Fixes: f9bbe4477c30 ("net: dsa: Optional VLAN-based port separation for switches without tagging")

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian