netdev - Re: [PATCH net 2/2] net: dsa: tag_8021q: Create a stable binary format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8577fda1-9104-2d2a-980f-91f4bb6c6f8e@gmail.com>
Date:   Tue, 28 May 2019 18:08:19 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, vivien.didelot@...il.com,
        andrew@...n.ch, davem@...emloft.net
Cc:     ioana.ciornei@....com, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: tag_8021q: Create a stable binary
 format



On 5/28/2019 3:50 PM, Vladimir Oltean wrote:
> Tools like tcpdump need to be able to decode the significance of fake
> VLAN headers that DSA uses to separate switch ports.
> 
> But currently these have no global significance - they are simply an
> ordered list of DSA_MAX_SWITCHES x DSA_MAX_PORTS numbers ending at 4095.
> 
> The reason why this is submitted as a fix is that the existing mapping
> of VIDs should not enter into a stable kernel, so we can pretend that
> only the new format exists. This way tcpdump won't need to try to make
> something out of the VLAN tags on 5.2 kernels.
> 
> Fixes: f9bbe4477c30 ("net: dsa: Optional VLAN-based port separation for switches without tagging")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

This looks a lot nicer actually, and kudos for documenting the format.
-- 
Florian