netdev - Re: [PATCH net-next] net: dsa: Add error path handling in dsa_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190529231753.GE18059@lunn.ch>
Date:   Thu, 30 May 2019 01:17:53 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     linux@...linux.org.uk, f.fainelli@...il.com, hkallweit1@...il.com,
        maxime.chevallier@...tlin.com, olteanv@...il.com,
        thomas.petazzoni@...tlin.com, davem@...emloft.net,
        vivien.didelot@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: Add error path handling in
 dsa_tree_setup()

> @@ -423,18 +434,41 @@ static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
>  
>  		err = dsa_switch_setup(ds);
>  		if (err)
> -			return err;
> +			goto setup_switch_err;

Minor nit pick.

All the other labels you add are err_*. This one is *_err.  A quick
look at dsa2.c, there is one label already in the file

out_put_node:

which has no prefix or postfix.

So maybe drop err_ and _err ?

   Andrew