netdev - Re: [PATCH net-next] net: dsa: Add error path handling in dsa_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB2800E8561AC18A2B4418BE3FE0180@VI1PR0402MB2800.eurprd04.prod.outlook.com>
Date:   Thu, 30 May 2019 05:48:33 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: Add error path handling in
 dsa_tree_setup()

On 5/30/19 2:17 AM, Andrew Lunn wrote:
>> @@ -423,18 +434,41 @@ static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
>>   
>>   		err = dsa_switch_setup(ds);
>>   		if (err)
>> -			return err;
>> +			goto setup_switch_err;
> 
> Minor nit pick.
> 
> All the other labels you add are err_*. This one is *_err.  A quick
> look at dsa2.c, there is one label already in the file
> 
> out_put_node:
> 
> which has no prefix or postfix.
> 
> So maybe drop err_ and _err ?

Sure, no problem. I'll send a v2.

--
Ioana

> 
>     Andrew
>