netdev - Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61d96859-ad26-68d8-6f91-56e7895b04d3@alvarezp.org>
Date:   Tue, 28 May 2019 22:59:24 -0500
From:   Octavio Alvarez <octallk1@...arezp.org>
To:     Petr Štetiar <ynezz@...e.cz>
Cc:     Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Subject: Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

On 5/18/19 8:22 PM, Octavio Alvarez wrote:
> Hi, Petr,
> 
>> I'm just shooting out of the blue, as I don't have currently any rational
>> explanation for that now, but could you please change the line above to
>> following:
>>
>>            if (!IS_ERR_OR_NULL(iap))
> 
> It worked! Thank you for being so quick!

Hi, Petr,

I just pulled from master and I don't see any updates for sky2.c.

What would be the next step for getting the fix into the kernel? I have 
never written a patch for the kernel before and I really don't know if 
it would break anything else or disrupt any future work.

Should I write a patch or should I let you do it? And if I do, should I 
just change IS_ERR for IS_ERR_OR_NULL for all the drivers on your 
original patch or just for the sky2?

I will be glad to help.

Thanks,
Octavio.