netdev - Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56e0a7a9-19e7-fb60-7159-6939bd6d8a45@alvarezp.org>
Date:   Sat, 18 May 2019 20:22:52 -0500
From:   Octavio Alvarez <octallk1@...arezp.org>
To:     Petr Štetiar <ynezz@...e.cz>
Cc:     Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Subject: Re: PROBLEM: [1/2] Marvell 88E8040 (sky2) stopped working

Hi, Petr,

On 5/18/19 4:58 PM, Petr Štetiar wrote:
>> Linux version 5.1.0-12511-g72cf0b07418a (alvarezp@...arezp-samsung)
> 
> What do I need to do/apply in order to get the same source tree with
> 72cf0b07418a hash? I'm not able to find that commit.

It's the most recent master, so my guess is just fetch it.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=72cf0b07418a9c8349aa9137194b1ccba6e54a9d

commit 72cf0b07418a9c8349aa9137194b1ccba6e54a9d (HEAD -> master,
origin/master, origin/HEAD)
Merge: 0ef0fd351550 56df90b631fc
Author: Linus Torvalds <torvalds@...ux-foundation.org>
Date:   Fri May 17 13:57:54 2019 -0700

    Merge tag 'sound-fix-5.2-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound

>>         iap = of_get_mac_address(hw->pdev->dev.of_node);
>> -       if (iap)
>> +       if (!IS_ERR(iap))
> 
> I'm just shooting out of the blue, as I don't have currently any rational
> explanation for that now, but could you please change the line above to
> following:
> 
>           if (!IS_ERR_OR_NULL(iap))

It worked! Thank you for being so quick!

$ sudo dmesg | grep sky2
[    1.520831] sky2: driver version 1.30
[    1.521197] sky2 0000:06:00.0: Yukon-2 FE+ chip revision 0
[    1.522574] sky2 0000:06:00.0 eth0: addr e8:11:32:8d:86:49
[   52.881706] sky2 0000:06:00.0 eth0: enabling interface
[   54.455020] sky2 0000:06:00.0 eth0: Link is up at 100 Mbps, full
duplex, flow control rx
[  235.562317] sky2 0000:06:00.0 eth0: disabling interface
[  238.947494] sky2 0000:06:00.0 eth0: enabling interface