Message-ID: <CADa=RyzQqRUWLEKfY6MuvBjN4MuGsB8dGcuDYBcOhx0SLyZJ1Q@mail.gmail.com>
Date:   Sat, 18 May 2019 18:20:36 -0700
From:   Joe Stringer <joe@...valent.com>
To:     Lorenz Bauer <lmb@...udflare.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Networking <netdev@...r.kernel.org>, bpf@...r.kernel.org,
        Martin Lau <kafai@...com>,
        Daniel Borkmann <daniel@...earbox.net>, edumazet@...gle.com
Subject: Re: RFC: Fixing SK_REUSEPORT from sk_lookup_* helpers

On Fri, May 17, 2019 at 7:15 AM Lorenz Bauer <lmb@...udflare.com> wrote:
>
> On Thu, 16 May 2019 at 21:33, Alexei Starovoitov
> <alexei.starovoitov@...il.com> wrote:
> >
> > On Thu, May 16, 2019 at 09:41:34AM +0100, Lorenz Bauer wrote:
> > > On Wed, 15 May 2019 at 18:16, Joe Stringer <joe@...valent.com> wrote:
> > > >
> > > > On Wed, May 15, 2019 at 8:11 AM Lorenz Bauer <lmb@...udflare.com> wrote:
> > > > >
> > > > > In the BPF-based TPROXY session with Joe Stringer [1], I mentioned
> > > > > that the sk_lookup_* helpers currently return inconsistent results if
> > > > > SK_REUSEPORT programs are in play.
> > > > >
> > > > > SK_REUSEPORT programs are a hook point in inet_lookup. They get access
> > > > > to the full packet
> > > > > that triggered the look up. To support this, inet_lookup gained a new
> > > > > skb argument to provide such context. If skb is NULL, the SK_REUSEPORT
> > > > > program is skipped and instead the socket is selected by its hash.
> > > > >
> > > > > The first problem is that not all callers to inet_lookup from BPF have
> > > > > an skb, e.g. XDP. This means that a look up from XDP gives an
> > > > > incorrect result. For now that is not a huge problem. However, once we
> > > > > get sk_assign as proposed by Joe, we can end up circumventing
> > > > > SK_REUSEPORT.
> > > >
> > > > To clarify a bit, the reason this is a problem is that a
> > > > straightforward implementation may just consider passing the skb
> > > > context into the sk_lookup_*() and through to the inet_lookup() so
> > > > that it would run the SK_REUSEPORT BPF program for socket selection on
> > > > the skb when the packet-path BPF program performs the socket lookup.
> > > > However, as this paragraph describes, the skb context is not always
> > > > available.
> > > >
> > > > > At the conference, someone suggested using a similar approach to the
> > > > > work done on the flow dissector by Stanislav: create a dedicated
> > > > > context sk_reuseport which can either take an skb or a plain pointer.
> > > > > Patch up load_bytes to deal with both. Pass the context to
> > > > > inet_lookup.
> > > > >
> > > > > This is when we hit the second problem: using the skb or XDP context
> > > > > directly is incorrect, because it assumes that the relevant protocol
> > > > > headers are at the start of the buffer. In our use case, the correct
> > > > > headers are at an offset since we're inspecting encapsulated packets.
> > > > >
> > > > > The best solution I've come up with is to steal 17 bits from the flags
> > > > > argument to sk_lookup_*, 1 bit for BPF_F_HEADERS_AT_OFFSET, 16bit for
> > > > > the offset itself.
> > > >
> > > > FYI there's also the upper 32 bits of the netns_id parameter, another
> > > > option would be to steal 16 bits from there.
> > >
> > > Or len, which is only 16 bits realistically. The offset doesn't really fit into
> > > either of them very well, using flags seemed the cleanest to me.
> > > Is there some best practice around this?
> > >
> > > >
> > > > > Thoughts?
> > > >
> > > > Internally with skbs, we use `skb_pull()` to manage header offsets,
> > > > could we do something similar with `bpf_xdp_adjust_head()` prior to
> > > > the call to `bpf_sk_lookup_*()`?
> > >
> > > That would only work if it retained the contents of the skipped
> > > buffer, and if there
> > > was a way to undo the adjustment later. We're doing the sk_lookup to
> > > decide whether to
> > > accept or forward the packet, so at the point of the call we might still need
> > > that data. Is that feasible with skb / XDP ctx?
> >
> > While discussing the solution for reuseport I propose to use
> > progs/test_select_reuseport_kern.c as an example of realistic program.
> > It reads tcp/udp header directly via ctx->data or via bpf_skb_load_bytes()
> > including payload after the header.
> > It also uses bpf_skb_load_bytes_relative() to fetch IP.
> > I think if we're fixing the sk_lookup from XDP the above program
> > would need to work.
>
> Agreed.
>
> > And I think we can make it work by adding new requirement that
> > 'struct bpf_sock_tuple *' argument to bpf_sk_lookup_* must be
> > a pointer to the packet and not a pointer to bpf program stack.
>
> This would break existing users, no? The sk_assign use case Joe Stringer
> is working on would also break, because its impossible to look up a tuple
> that hasn't come from the network.

Right, in practice the bpf prog sk lookups for tproxy use case look
like first, look up with packet tuple, then if no tproxied socket is
found, substitute the destination port with the pre-configured tproxy
port and look up. Requiring packet pointer means rewriting the packet
for this case (not to mention the ext hdrs case that Lorenz mentions
below).

> It occurs to me that it's impossible to reconcile this use case with
> SK_REUSEPORT in general. It would be great if we could return an
> error in such case.
>
> > Then helper can construct a fake skb and assign
> > fake_skb->data = &bpf_sock_tuple_arg.sport
>
> That isn't valid if the packet contains IP options or extension headers, because
> the offset of sport is variable.
>
> > It can check that struct bpf_sock_tuple * pointer is within 100-ish bytes
> > from xdp->data and within xdp->data_end
>
> Why the 100-byte limitation?
>
> > This way the reuseport program's assumption that ctx->data points to tcp/udp
> > will be preserved and it can access it all including payload.
>
> How about the following:
>
>     sk_lookup(ctx, &saddr, len, netns, BPF_F_IPV4 |
> BPF_F_OFFSET(offsetof(sport))
>
> SK_REUSEPORT can then access from saddr+offsetof(sport) to saddr+len.
> The helper uses
> offsetof(sport) to retrieve the tuple.
>
> - Works with stack, map, packet pointers
> - The verifier does bounds checking on the buffer for us due to ARG_CONST_SIZE
> - If no BPF_F_IPV? is present, we fall back to current behaviour
>
> >
> > This approach doesn't need to mess with xdp_adjust_head and adjust uapi to pass length.
> > Existing progs/test_sk_lookup_kern.c will magically start working with XDP
> > even when reuseport prog is attached.
> > Thoughts?
> >
>
>
> --
> Lorenz Bauer  |  Systems Engineer
> 6th Floor, County Hall/The Riverside Building, SE1 7PB, UK
>
> www.cloudflare.com

Powered by blists - more mailing lists