netdev - Re: [PATCH V4 net-next 2/6] net: Introduce a new MII time stamping interface.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201906010107.Rldph9o4%lkp@intel.com>
Date:   Sat, 1 Jun 2019 01:08:46 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        David Miller <davem@...emloft.net>, devicetree@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Mark Rutland <mark.rutland@....com>,
        Miroslav Lichvar <mlichvar@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH V4 net-next 2/6] net: Introduce a new MII time stamping
 interface.

Hi Richard,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Richard-Cochran/Peer-to-Peer-One-Step-time-stamping/20190531-213601
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/ti/netcp_ethss.c: In function 'gbe_txtstamp_mark_pkt':
>> drivers/net/ethernet/ti/netcp_ethss.c:2535:50: error: 'struct phy_driver' has no member named 'txtstamp'
    #define HAS_PHY_TXTSTAMP(p) ((p)->drv && (p)->drv->txtstamp)
                                                     ^
   drivers/net/ethernet/ti/netcp_ethss.c:2568:16: note: in expansion of macro 'HAS_PHY_TXTSTAMP'
     if (phydev && HAS_PHY_TXTSTAMP(phydev)) {
                   ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/ti/netcp_ethss.c: In function 'gbe_rxtstamp':
>> drivers/net/ethernet/ti/netcp_ethss.c:2536:50: error: 'struct phy_driver' has no member named 'rxtstamp'
    #define HAS_PHY_RXTSTAMP(p) ((p)->drv && (p)->drv->rxtstamp)
                                                     ^
   drivers/net/ethernet/ti/netcp_ethss.c:2590:16: note: in expansion of macro 'HAS_PHY_RXTSTAMP'
     if (phydev && HAS_PHY_RXTSTAMP(phydev)) {
                   ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/ti/netcp_ethss.c: In function 'gbe_ioctl':
>> drivers/net/ethernet/ti/netcp_ethss.c:2832:23: error: 'struct phy_driver' has no member named 'hwtstamp'
     if (!phy || !phy->drv->hwtstamp) {
                          ^~

vim +2535 drivers/net/ethernet/ti/netcp_ethss.c

6f8d3f33 Wingman Kwok 2015-01-15  2533  
6246168b WingMan Kwok 2016-12-08  2534  #if IS_ENABLED(CONFIG_TI_CPTS)
6246168b WingMan Kwok 2016-12-08 @2535  #define HAS_PHY_TXTSTAMP(p) ((p)->drv && (p)->drv->txtstamp)
6246168b WingMan Kwok 2016-12-08 @2536  #define HAS_PHY_RXTSTAMP(p) ((p)->drv && (p)->drv->rxtstamp)
6246168b WingMan Kwok 2016-12-08  2537  

:::::: The code at line 2535 was first introduced by commit
:::::: 6246168b4a38357b135d07370464f27d4f3a68ce net: ethernet: ti: netcp: add support of cpts

:::::: TO: WingMan Kwok <w-kwok2@...com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (70940 bytes)