netdev - Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+yj28xchvW6jCPfXCneuHxN+0MNHVquA1v10rWQ=dBMQ@mail.gmail.com>
Date:   Fri, 31 May 2019 19:51:49 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        David Ahern <dsahern@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        Ido Schimmel <idosch@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Martin KaFai Lau <kafai@...com>, Wei Wang <weiwan@...gle.com>
Subject: Re: [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info

On Fri, May 31, 2019 at 2:38 PM David Ahern <dsahern@...il.com> wrote:
>
> On 5/31/19 3:29 PM, David Miller wrote:
> > David, can you add some supplementary information to your cover letter
> > et al.  which seems to be part of what Alexei is asking for and seems
> > quite reasonable?
> >
>
> It is not clear to me what more is wanted in the cover letter. His
> complaints were on lack of tests. I sent those separately; they really
> aren't tied to this specific set (most of them apply to the previous set
> which provided the uapi and core implementation). This set is mostly
> mechanical in adding wrappers to 2 fields and shoving existing code into
> the else branch of 'if (fi->nh) { new code } else { existing code }'

Are you talking about this one?
https://patchwork.ozlabs.org/patch/1107892/
>From single sentence of commit log it's not clear at all
whether they're related to this thread.
Will they fail if run w/o this set?