netdev - RE: [PATCH net-next] qed: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB31826214544CB3DFD79A2671A11B0@MN2PR18MB3182.namprd18.prod.outlook.com>
Date:   Sun, 2 Jun 2019 07:50:05 +0000
From:   Michal Kalderon <mkalderon@...vell.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        Ariel Elior <aelior@...vell.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] qed: Fix build error without CONFIG_DEVLINK

> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org>
> On Behalf Of YueHaibing
> 
> Fix gcc build error while CONFIG_DEVLINK is not set
> 
> drivers/net/ethernet/qlogic/qed/qed_main.o: In function `qed_remove':
> qed_main.c:(.text+0x1eb4): undefined reference to `devlink_unregister'
> 
> Select DEVLINK to fix this.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 24e04879abdd ("qed: Add qed devlink parameters table")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/net/ethernet/qlogic/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/qlogic/Kconfig
> b/drivers/net/ethernet/qlogic/Kconfig
> index fdbb3ce..a391cf6 100644
> --- a/drivers/net/ethernet/qlogic/Kconfig
> +++ b/drivers/net/ethernet/qlogic/Kconfig
> @@ -87,6 +87,7 @@ config QED
>  	depends on PCI
>  	select ZLIB_INFLATE
>  	select CRC8
> +	select NET_DEVLINK
>  	---help---
>  	  This enables the support for ...
> 
> --
> 2.7.4
> 

Thanks, 

Acked-by: Michal Kalderon <michal.kalderon@...vell.com>