netdev - Re: [PATCH 1/1] net: rds: add per rds connection cache statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9164a0b-fb6f-b3ab-1d38-76413e4820b2@oracle.com>
Date:   Sun, 2 Jun 2019 20:03:02 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Zhu Yanjun <yanjun.zhu@...cle.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCH 1/1] net: rds: add per rds connection cache statistics

On 6/1/19 12:54 AM, Zhu Yanjun wrote:
> The variable cache_allocs is to indicate how many frags (KiB) are in one
> rds connection frag cache.
> The command "rds-info -Iv" will output the rds connection cache
> statistics as below:
> "
> RDS IB Connections:
>        LocalAddr RemoteAddr Tos SL  LocalDev            RemoteDev
>        1.1.1.14 1.1.1.14   58 255  fe80::2:c903:a:7a31 fe80::2:c903:a:7a31
>        send_wr=256, recv_wr=1024, send_sge=8, rdma_mr_max=4096,
>        rdma_mr_size=257, cache_allocs=12
> "
> This means that there are about 12KiB frag in this rds connection frag
>   cache.
> 
> Tested-by: RDS CI <rdsci_oslo@...oracle.com>
Please add some valid email id or drop above. Its expected
that with SOB, patches are tested before testing.

> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
> ---
>   include/uapi/linux/rds.h | 2 ++
>   net/rds/ib.c             | 2 ++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
> index 5d0f76c..fd6b5f6 100644
> --- a/include/uapi/linux/rds.h
> +++ b/include/uapi/linux/rds.h
> @@ -250,6 +250,7 @@ struct rds_info_rdma_connection {
>   	__u32		rdma_mr_max;
>   	__u32		rdma_mr_size;
>   	__u8		tos;
> +	__u32		cache_allocs;
Some of this header file changes, how is taking care of backward
compatibility with tooling ? This was one of the reason, the
all the fields are not updated.

Regards,
Santosh