netdev - Re: [PATCH 1/1] net: rds: add per rds connection cache statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3552e6e4-7dde-51c7-aee6-005fbccfbf4e@oracle.com>
Date:   Mon, 3 Jun 2019 12:08:07 +0800
From:   Yanjun Zhu <yanjun.zhu@...cle.com>
To:     "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCH 1/1] net: rds: add per rds connection cache statistics


On 2019/6/3 11:03, santosh.shilimkar@...cle.com wrote:
> On 6/1/19 12:54 AM, Zhu Yanjun wrote:
>> The variable cache_allocs is to indicate how many frags (KiB) are in one
>> rds connection frag cache.
>> The command "rds-info -Iv" will output the rds connection cache
>> statistics as below:
>> "
>> RDS IB Connections:
>>        LocalAddr RemoteAddr Tos SL  LocalDev RemoteDev
>>        1.1.1.14 1.1.1.14   58 255  fe80::2:c903:a:7a31 
>> fe80::2:c903:a:7a31
>>        send_wr=256, recv_wr=1024, send_sge=8, rdma_mr_max=4096,
>>        rdma_mr_size=257, cache_allocs=12
>> "
>> This means that there are about 12KiB frag in this rds connection frag
>>   cache.
>>
>> Tested-by: RDS CI <rdsci_oslo@...oracle.com>
> Please add some valid email id or drop above. Its expected
> that with SOB, patches are tested before testing.

Thanks for review.

OK. I will remove this in V2.

>
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
>> ---
>>   include/uapi/linux/rds.h | 2 ++
>>   net/rds/ib.c             | 2 ++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
>> index 5d0f76c..fd6b5f6 100644
>> --- a/include/uapi/linux/rds.h
>> +++ b/include/uapi/linux/rds.h
>> @@ -250,6 +250,7 @@ struct rds_info_rdma_connection {
>>       __u32        rdma_mr_max;
>>       __u32        rdma_mr_size;
>>       __u8        tos;
>> +    __u32        cache_allocs;
> Some of this header file changes, how is taking care of backward
> compatibility with tooling ? 

Just now I made tests with rds-tools.

In this commit

"

commit 6c03b61e9097098d35b4c2be16d0f0f9f8357112
Author: Santosh Shilimkar <santosh.shilimkar@...cle.com>
Date:   Wed Mar 9 04:30:48 2016 -0800

     rds-tools: sync up sources with 2.0.7-1.16
"

cache_allocs is added into rds-tools. The diff is as below.

"

@@ -176,6 +191,9 @@ struct rds_info_rdma_connection {
         uint32_t        max_send_sge;
         uint32_t        rdma_mr_max;
         uint32_t        rdma_mr_size;
+       uint8_t         tos;
+       uint8_t         sl;
+       uint32_t        cache_allocs;
  };
"
Then this cache_allocs does not exist in rds-tools 2.0.6 and rds-tools 
2.0.5.

I made tests with 2.0.5 and 2.0.6

"

rds-info -V
rds-info: Invalid option '-V'
rds-info version 2.0.5

[root@...dev14 rds-tools]# rds-info -Iv

RDS IB Connections:
       LocalAddr      RemoteAddr LocalDev                        RemoteDev
        1.1.1.14        1.1.1.14 fe80::2:c903:a:7a31              
fe80::2:c903:a:7a31  send_wr=256, recv_wr=1024, send_sge=8, 
rdma_mr_max=4096, rdma_mr_size=257
"

"

[root@...dev14 rds-tools]# rds-info -V
rds-info: Invalid option '-V'
rds-info version 2.0.6

[root@...dev14 rds-tools]# rds-info -Iv

RDS IB Connections:
       LocalAddr      RemoteAddr LocalDev                        RemoteDev
        1.1.1.14        1.1.1.14 fe80::2:c903:a:7a31              
fe80::2:c903:a:7a31  send_wr=256, recv_wr=1024, send_sge=8, 
rdma_mr_max=4096, rdma_mr_size=257
"

 From output of rds-tools 2.0.5 and 2.0.6, cache_allocs does not appear 
since cache_allocs does not exist in struct rds_info_rdma_connection.

But in rds-tools 2.0.7, cache_allocs exists in struct 
rds_info_rdma_connection.

"

[root@...dev14 rds-tools]# rds-info -V
rds-info: invalid option -- 'V'

rds-info version 2.0.7

[root@...dev14 rds-tools]# rds-info -Iv

RDS IB Connections:
       LocalAddr      RemoteAddr  Tos  SL 
LocalDev                        RemoteDev
        1.1.1.14        1.1.1.14    5 255 
fe80::2:c903:a:7a31              fe80::2:c903:a:7a31  send_wr=256, 
recv_wr=1024, send_sge=8, rdma_mr_max=4096, rdma_mr_size=257, 
cache_allocs=12
"

So do not worry about backward compatibility.  This commit will work 
well with older rds-tools2.0.5 and 2.0.6.

I will send V2 soon.

Thanks

Zhu Yanjun

> This was one of the reason, the
> all the fields are not updated.
>
> Regards,
> Santosh