netdev - Re: [PATCH net v2] net: fix indirect calls helpers for ptype list hooks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLTB=N663kU8p+98hVHYvU3osb-iQ473SdFW9ZTXdsvng@mail.gmail.com>
Date:   Tue, 4 Jun 2019 06:37:10 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Edward Cree <ecree@...arflare.com>
Subject: Re: [PATCH net v2] net: fix indirect calls helpers for ptype list hooks.

On Tue, Jun 4, 2019 at 2:45 AM Paolo Abeni <pabeni@...hat.com> wrote:
>
> As Eric noted, the current wrapper for ptype func hook inside
> __netif_receive_skb_list_ptype() has no chance of avoiding the indirect
> call: we enter such code path only for protocols other than ipv4 and
> ipv6.
>
> Instead we can wrap the list_func invocation.
>
> v1 -> v2:
>  - use the correct fix tag
>
> Fixes: f5737cbadb7d ("net: use indirect calls helpers for ptype hook")
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> Acked-by: Edward Cree <ecree@...arflare.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>