netdev - Re: [PATCH net v2] net: fix indirect calls helpers for ptype list hooks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 04 Jun 2019 20:16:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, ecree@...arflare.com, edumazet@...gle.com
Subject: Re: [PATCH net v2] net: fix indirect calls helpers for ptype list
 hooks.

From: Paolo Abeni <pabeni@...hat.com>
Date: Tue,  4 Jun 2019 11:44:06 +0200

> As Eric noted, the current wrapper for ptype func hook inside
> __netif_receive_skb_list_ptype() has no chance of avoiding the indirect
> call: we enter such code path only for protocols other than ipv4 and
> ipv6.
> 
> Instead we can wrap the list_func invocation.
> 
> v1 -> v2:
>  - use the correct fix tag
> 
> Fixes: f5737cbadb7d ("net: use indirect calls helpers for ptype hook")
> Suggested-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> Acked-by: Edward Cree <ecree@...arflare.com>

Applied.