netdev - Re: [PATCH net-next v4 07/20] net: axienet: Re-initialize MDIO registers properly after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190606.140503.320240166416804603.davem@davemloft.net>
Date:   Thu, 06 Jun 2019 14:05:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hancock@...systems.ca
Cc:     netdev@...r.kernel.org, anirudh@...inx.com, John.Linn@...inx.com,
        andrew@...n.ch
Subject: Re: [PATCH net-next v4 07/20] net: axienet: Re-initialize MDIO
 registers properly after reset

From: Robert Hancock <hancock@...systems.ca>
Date: Wed,  5 Jun 2019 14:42:20 -0600

> +int axienet_mdio_setup(struct axienet_local *lp)
> +{
> +	int ret;
> +	struct mii_bus *bus;
> +	struct device_node *mdio_node;

Please use reverse christmas tree ordering (longest to shortest line) for
local variables.